Skip to content

doc: exclude commits with baking-for-lts#52896

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
marco-ippolito:fix/baking-for-lts
May 10, 2024
Merged

doc: exclude commits with baking-for-lts#52896
nodejs-github-bot merged 1 commit intonodejs:mainfrom
marco-ippolito:fix/baking-for-lts

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented May 8, 2024 •
edited
Loading

Add baking-for-lts to the exclude label

cc @nodejs/releasers

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 8, 2024

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 8, 2024
targos
targos reviewed May 8, 2024
View reviewed changes
@aduh95
Copy link
Contributor

aduh95 commented May 8, 2024

Is there a way to still include those commits if they have been on Current for long enough?

@marco-ippolito
Copy link
Member Author

marco-ippolito commented May 8, 2024

Is there a way to still include those commits if they have been on Current for long enough?

remove the label

@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 8, 2024
mhdawson
mhdawson approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

UlisesGascon
UlisesGascon approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit dee061a into nodejs:main May 10, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 10, 2024

Landed in dee061a

targos pushed a commit that referenced this pull request May 11, 2024
@marco-ippolito @targos
doc: exclude commits with baking-for-lts
2dd8f09 
PR-URL: #52896
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request May 13, 2024
Merged
marco-ippolito added a commit that referenced this pull request Jun 17, 2024
@marco-ippolito
doc: exclude commits with baking-for-lts
ca9e059 
PR-URL: #52896
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito added a commit that referenced this pull request Jun 17, 2024
@marco-ippolito
doc: exclude commits with baking-for-lts
ef1a15a 
PR-URL: #52896
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito added a commit that referenced this pull request Jun 17, 2024
@marco-ippolito
doc: exclude commits with baking-for-lts
1e429d1 
PR-URL: #52896
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@marco-ippolito @eliphazbouye
doc: exclude commits with baking-for-lts
95898bb 
PR-URL: nodejs#52896
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@marco-ippolito @bmeck
doc: exclude commits with baking-for-lts
045773c 
PR-URL: nodejs#52896
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@benjamingr benjamingr benjamingr approved these changes

@targos targos targos approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@marco-ippolito @nodejs-github-bot @aduh95 @ruyadorno @benjamingr @targos @UlisesGascon @richardlau @mhdawson @RafaelGSS