doc: document watermark string behavior #52842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
lpinca
approved these changes
May 5, 2024
|
I'm not sure if the "but not decoding" bit is sufficient, it might be a bit too generic for someone not familiar with the implementation, but I can't think of anything better to suggest. |
ronag
approved these changes
May 5, 2024
Documents that we calculate the highWaterMark value of streams operating on strings using the number of UTF-16 code units. Fixes: #52818
benjamingr
force-pushed
the
stream-string-length
branch
from
a5c8454 to
3e96ac3
Compare
aymen94
approved these changes
May 7, 2024
avivkeller
added
the
author ready
|
(3[+1] approving reviews; no failed tests) |
|
Landed in 761d2ce |
Merged
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
Documents that we calculate the highWaterMark value of streams operating on strings using the number of UTF-16 code units. Fixes: nodejs#52818 PR-URL: nodejs#52842 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Documents that we calculate the highWaterMark value of streams operating on strings using the number of UTF-16 code units. Fixes: nodejs#52818 PR-URL: nodejs#52842 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bikeshedding/doc suggestions (should we edit it in other places like (readableLength/writableLength?) welcome
ping @lpinca @nodejs/streams
Documents that we calculate the highWaterMark value of streams operating on strings using the number of UTF-16 code units.
Fixes: #52818