-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dgram: do not call callback if socket is closed #52829
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
theanarkh:dont-emit-error-after-close-handle
May 23, 2024
Merged
dgram: do not call callback if socket is closed #52829
nodejs-github-bot
merged 1 commit into
nodejs:main
from
theanarkh:dont-emit-error-after-close-handle
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
dgram
Issues and PRs related to the dgram subsystem / UDP.
needs-ci
PRs that need a full CI run.
labels
May 4, 2024
github-actions
bot
added
request-ci-failed
An error occurred while starting CI via request-ci label, and manual interventon is needed.
and removed
request-ci
Add this label to start a Jenkins CI on a PR.
labels
May 4, 2024
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/8949880553 |
mcollina
reviewed
May 6, 2024
ShogunPanda
reviewed
May 15, 2024
mcollina
changed the title
lib: do not call callback if socket is closed
dgram: do not call callback if socket is closed
May 15, 2024
mcollina
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm so we can start CI
mcollina
added
request-ci
Add this label to start a Jenkins CI on a PR.
and removed
request-ci-failed
An error occurred while starting CI via request-ci label, and manual interventon is needed.
labels
May 15, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 15, 2024
theanarkh
force-pushed
the
dont-emit-error-after-close-handle
branch
from
May 15, 2024 11:48
9aeee94
to
d022b6c
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 18, 2024
mcollina
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 19, 2024
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
May 19, 2024
Commit Queue failed- Loading data for nodejs/node/pull/52829 ✔ Done loading data for nodejs/node/pull/52829 ----------------------------------- PR info ------------------------------------ Title dgram: do not call callback if socket is closed (#52829) Author theanarkh (@theanarkh) Branch theanarkh:dont-emit-error-after-close-handle -> nodejs:main Labels dgram, needs-ci Commits 1 - lib: do not call callback if socket is closed Committers 1 - theanarkh PR-URL: https://github.com/nodejs/node/pull/52829 Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52829 Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - lib: do not call callback if socket is closed ℹ This PR was created on Sat, 04 May 2024 07:58:48 GMT ✔ Approvals: 1 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/52829#pullrequestreview-2057177270 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-05-18T07:21:46Z: https://ci.nodejs.org/job/node-test-pull-request/59282/ - Querying data for job/node-test-pull-request/59282/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9146455101 |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 19, 2024
theanarkh
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 20, 2024
mcollina
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mcollina
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 23, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 23, 2024
Landed in f05baff |
targos
pushed a commit
that referenced
this pull request
Jun 1, 2024
PR-URL: #52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
dgram
Issues and PRs related to the dgram subsystem / UDP.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not call callback if socket is closed.
make -j4 test
(UNIX), orvcbuild test
(Windows) passes