Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: compile with C++20 support when using Clang #52819

Closed
wants to merge 1 commit into from
Closed

build: compile with C++20 support when using Clang #52819

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented May 3, 2024 •
edited
Loading

This is required by V8 12.6+

Refs: v8/v8@4421c36
Refs: #45402

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 3, 2024
@targos targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 3, 2024
@targos
Copy link
Member Author

targos commented May 3, 2024

Here's the corresponding canary build failure: https://github.com/nodejs/node-v8/actions/runs/8935543080/job/24544213633

Repro with godbolt

Note that the problem is not specific to Clang, but the build infra is still not ready to enable C++20 on some Linux hosts.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58894/

@targos targos added the wip Issues and PRs that are still a work in progress. label May 3, 2024
@targos
Copy link
Member Author

targos commented May 3, 2024 •
edited
Loading

We may actually be close to fixing #45427

@targos targos closed this May 4, 2024
@targos targos deleted the c++20-clang branch May 4, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @nodejs-github-bot @anonrig @richardlau