Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v20.x] backport libuv wtf-8 decoding fix #51976

Closed
wants to merge 2 commits into from
Closed

[v20.x] backport libuv wtf-8 decoding fix #51976

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c623d8e
deps: cherry-pick libuv/libuv@d09441c
richardlau Mar 1, 2024
d540f55
test: test surrogate pair filenames on windows
mertcanaltin Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
deps: cherry-pick libuv/libuv@d09441c 
Original commit message:

    fs: fix WTF-8 decoding issue (#4092)

    We forgot to mask off the high bits from the first byte, so we ended up
    always failing the subsequent range check.

    Refs: libuv/libuv#2970
    Fixes: #48673
  • Loading branch information
@richardlau
richardlau committed Mar 5, 2024
commit c623d8e586fad0329c6f7d14912b039232c7345f
4 changes: 3 additions & 1 deletion deps/uv/src/win/fs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,9 +176,11 @@ static int32_t fs__decode_wtf8_char(const char** input) {
if ((b4 & 0xC0) != 0x80)
return -1; /* invalid: not a continuation byte */
code_point = (code_point << 6) | (b4 & 0x3F);
if (b1 <= 0xF4)
if (b1 <= 0xF4) {
code_point &= 0x1FFFFF;
if (code_point <= 0x10FFFF)
return code_point; /* four-byte character */
}

/* code point too large */
return -1;
Expand Down