build: fix building js2c with GN #51818
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
added
fast-track
Contributor
|
Fast-track has been requested by @zcbenz. Please 👍 to approve. |
Contributor
Author
|
Adding a fast-track label since this is blocking the GN build. |
github-actions
bot
removed
the
request-ci
Collaborator
targos
approved these changes
Feb 21, 2024
joyeecheung
approved these changes
Feb 21, 2024
anonrig
approved these changes
Feb 21, 2024
lpinca
approved these changes
Feb 21, 2024
Collaborator
This is a follow-up to nodejs#51605.
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
zcbenz
added
commit-queue-squash
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/51818 ✔ Done loading data for nodejs/node/pull/51818 ----------------------------------- PR info ------------------------------------ Title build: fix building js2c with GN (#51818) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch zcbenz:fix-js2c-gn -> nodejs:main Labels fast-track, commit-queue-squash Commits 1 - build: fix building js2c with GN Committers 1 - Cheng Zhao PR-URL: https://github.com/nodejs/node/pull/51818 Reviewed-By: Michaël Zasso Reviewed-By: Joyee Cheung Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51818 Reviewed-By: Michaël Zasso Reviewed-By: Joyee Cheung Reviewed-By: Yagiz Nizipli Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - build: fix building js2c with GN ℹ This PR was created on Wed, 21 Feb 2024 06:37:16 GMT ✔ Approvals: 4 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/51818#pullrequestreview-1892231320 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51818#pullrequestreview-1893579234 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51818#pullrequestreview-1894189988 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51818#pullrequestreview-1894332575 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8015803850 |
Contributor
Author
|
Landed in 0992002 |
Merged
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
This is a follow-up to nodejs#51605. PR-URL: nodejs#51818 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #51605.