test: remove flaky designation#51736
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 2, 2024
Merged
Conversation
nodejs-github-bot
added
needs-ci
lpinca
force-pushed
the
remove/flaky-test-worker-message-port-message-before-close
branch
from
04fdef5 to
d893058
Compare
Contributor
|
Isn't it because of nodejs/build#3598? |
Member
Author
|
There should be failures in https://github.com/nodejs/reliability/issues before nodejs/build#3598 landed, no? |
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Searching the automatically-generated test failure reports in the issues at https://github.com/nodejs/reliability/issues, I don't see `test-worker-message-port-message-before-close` failing any time recently.
lpinca
force-pushed
the
remove/flaky-test-worker-message-port-message-before-close
branch
from
d893058 to
ff2b674
Compare
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Member
|
I don't think the reliability report considers tests that are marked as flaky: https://github.com/nodejs/node-core-utils/blob/0d49edaf6736b393b0597ee67d70381cd5841b40/lib/ci/ci_failure_parser.js#L157-L170 (perhaps we should, for the walk command used by the reliability report), but as far as I've seen it's not been failing recently. |
joyeecheung
approved these changes
Feb 27, 2024
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 5c97f41 |
lpinca
deleted the
remove/flaky-test-worker-message-port-message-before-close
branch
targos
pushed a commit
that referenced
this pull request
Mar 7, 2024
Searching the automatically-generated test failure reports in the issues at https://github.com/nodejs/reliability/issues, I don't see `test-worker-message-port-message-before-close` failing any time recently. PR-URL: #51736 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Searching the automatically-generated test failure reports in the issues at https://github.com/nodejs/reliability/issues, I don't see `test-worker-message-port-message-before-close` failing any time recently. PR-URL: #51736 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Searching the automatically-generated test failure reports in the issues at https://github.com/nodejs/reliability/issues, I don't see `test-worker-message-port-message-before-close` failing any time recently. PR-URL: #51736 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
Searching the automatically-generated test failure reports in the issues at https://github.com/nodejs/reliability/issues, I don't see `test-worker-message-port-message-before-close` failing any time recently. PR-URL: nodejs#51736 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching the automatically-generated test failure reports in the issues at https://github.com/nodejs/reliability/issues, I don't see
test-worker-message-port-message-before-closefailing any time recently.