url,tools,benchmark: replace deprecated substr()#51546
Merged
aduh95 merged 1 commit intonodejs:mainfrom May 12, 2024
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Member
|
If we are doing this, we should add a ESLint rule to avoid making the same decision over and over again. |
pluris
force-pushed
the
fix/depre_url
branch
2 times, most recently
from
7242e8c to
879629c
Compare
Contributor
Author
|
@anonrig Thank you for your good opinion. |
marco-ippolito
approved these changes
Jan 23, 2024
lpinca
approved these changes
Jan 23, 2024
hulkish
reviewed
Jan 23, 2024
lib/url.js
Outdated
|
|
||
| if (hasTrailingSlash && (srcPath.join('/').substr(-1) !== '/')) { | ||
| const srcPathSlashes = srcPath.join('/'); | ||
| if (hasTrailingSlash && (srcPathSlashes.substring(srcPathSlashes.length - 1) !== '/')) { |
There was a problem hiding this comment.
shouldn't this be srcPathSlashes.charAt(-1) instead of srcPathSlashes.substring(srcPathSlashes.length - 1)?
Member
There was a problem hiding this comment.
srcPathSlashes.charAt(srcPathSlashes.length -1)
There was a problem hiding this comment.
srcPathSlashes.charAt(srcPathSlashes.length -1)
hmm I mean sure... but .charAt(-1) accomplishes the same result
Contributor
Author
There was a problem hiding this comment.
.charAt(-1) works differently than before. I think .slice(-1) is correct for this case. Thank you for your opinion.
lpinca
approved these changes
Jan 23, 2024
Contributor
Author
|
I had divided the commits for review, but I will merge them into one and edit the First commit message. |
pluris
force-pushed
the
fix/depre_url
branch
2 times, most recently
from
1b33e8a to
07f751c
Compare
pluris
changed the title
substr() -> substring()substr()
pluris
force-pushed
the
fix/depre_url
branch
from
07f751c to
094c72d
Compare
aduh95
added
the
author ready
Collaborator
Collaborator
Contributor
|
Landed in 78dbda1 |
targos
pushed a commit
that referenced
this pull request
May 13, 2024
PR-URL: #51546 Refs: https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Global_Objects/String/substr Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #51546 Refs: https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Global_Objects/String/substr Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #51546 Refs: https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Global_Objects/String/substr Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
PR-URL: #51546 Refs: https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Global_Objects/String/substr Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#51546 Refs: https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Global_Objects/String/substr Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#51546 Refs: https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Global_Objects/String/substr Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace deprecated API.
Refs: https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Global_Objects/String/substr