doc: fix type of connectionAttempt parameter #51490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
lpinca
approved these changes
Jan 16, 2024
ShogunPanda
approved these changes
Jan 16, 2024
Contributor
ShogunPanda
left a comment
ShogunPanda
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for fixing my copy-paste 🤣
Contributor
|
How about to fix for |
RafaelGSS
added
commit-queue
RafaelGSS
force-pushed
the
net-doc-fix
branch
from
d301746 to
46d28f5
Compare
Member
Author
Good catch! |
ShogunPanda
approved these changes
Jan 17, 2024
UlisesGascon
approved these changes
Jan 19, 2024
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in e1d3ad4 |
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 22, 2024
PR-URL: nodejs#51490 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 2, 2024
PR-URL: nodejs#51490 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51490 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 19, 2024
PR-URL: nodejs#51490 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51490 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51490 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://github.com/nodejs/node/pull/51045/files/159f874f1f01529510754c1124523cd8ba7dcb8e#r1452516815