Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: console is asynchronous unless it's a file #5133

Merged
merged 1 commit into from
Feb 7, 2016
Merged

doc: console is asynchronous unless it's a file #5133

merged 1 commit into from
Feb 7, 2016

Conversation

bnoordhuis
Copy link
Member

Mea culpa, looks like I forgot to update console.markdown in commit
dac1d38 ("doc: stdout/stderr can block when directed to file").
This commit rectifies that.

Refs: #5131

@bnoordhuis bnoordhuis added the doc Issues and PRs related to the documentations. label Feb 7, 2016
@evanlucas
Copy link
Contributor

LGTM

@mscdex mscdex added the console Issues and PRs related to the console subsystem. label Feb 7, 2016
@mscdex
Copy link
Contributor

mscdex commented Feb 7, 2016

LGTM

@bnoordhuis
doc: console is asynchronous unless it's a file
eaa9e0e 
Mea culpa, looks like I forgot to update console.markdown in commit
dac1d38 ("doc: stdout/stderr can block when directed to file").
This commit rectifies that.

Refs: nodejs#5131
PR-URL: nodejs#5133
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@bnoordhuis bnoordhuis closed this Feb 7, 2016
@bnoordhuis bnoordhuis deleted the doc-console-async branch February 7, 2016 22:29
@bnoordhuis bnoordhuis merged commit eaa9e0e into nodejs:master Feb 7, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
@bnoordhuis @rvagg
doc: console is asynchronous unless it's a file
6f58bc5 
Mea culpa, looks like I forgot to update console.markdown in commit
dac1d38 ("doc: stdout/stderr can block when directed to file").
This commit rectifies that.

Refs: #5131
PR-URL: #5133
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
rvagg pushed a commit that referenced this pull request Feb 9, 2016
@bnoordhuis @rvagg
doc: console is asynchronous unless it's a file
a96ae2c 
Mea culpa, looks like I forgot to update console.markdown in commit
dac1d38 ("doc: stdout/stderr can block when directed to file").
This commit rectifies that.

Refs: #5131
PR-URL: #5133
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
@bnoordhuis
doc: console is asynchronous unless it's a file
9f7a543 
Mea culpa, looks like I forgot to update console.markdown in commit
dac1d38 ("doc: stdout/stderr can block when directed to file").
This commit rectifies that.

Refs: #5131
PR-URL: #5133
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
@bnoordhuis
doc: console is asynchronous unless it's a file
f615cd5 
Mea culpa, looks like I forgot to update console.markdown in commit
dac1d38 ("doc: stdout/stderr can block when directed to file").
This commit rectifies that.

Refs: #5131
PR-URL: #5133
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
@bnoordhuis
doc: console is asynchronous unless it's a file
366625c 
Mea culpa, looks like I forgot to update console.markdown in commit
dac1d38 ("doc: stdout/stderr can block when directed to file").
This commit rectifies that.

Refs: #5131
PR-URL: #5133
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@bnoordhuis
doc: console is asynchronous unless it's a file
5598202 
Mea culpa, looks like I forgot to update console.markdown in commit
dac1d38 ("doc: stdout/stderr can block when directed to file").
This commit rectifies that.

Refs: nodejs#5131
PR-URL: nodejs#5133
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
console Issues and PRs related to the console subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bnoordhuis @evanlucas @mscdex @jasnell @MylesBorins