build: update gn build flags for deps

[zcbenz]

V8 recently updated node-ci to use a newer version of clang, which requires us to disable a few warnings in deps.

[zcbenz]

/cc @nodejs/gyp @anonrig

[anonrig]

cc @lemire maybe we can fix it upstream

[zcbenz]

We can try to fix them upstream, but it will not just be a few lines changes.

Some of the errors are from machine generated code:

../../node/deps/simdutf/simdutf.cpp:26609:34: error: code will never be executed [-Werror,-Wunreachable-code]
 26609 |   std::pair<result, char*> ret = avx2_convert_utf32_to_latin1_with_errors(buf, len, latin1_output);
       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

simdutf_warn_unused result implementation::convert_utf32_to_latin1_with_errors(const char32_t* buf, size_t len, char* latin1_output) const noexcept {
  return scalar::utf32_to_latin1::convert_with_errors(buf,len,latin1_output);
  std::pair<result, char*> ret = avx2_convert_utf32_to_latin1_with_errors(buf, len, latin1_output);

And some are intentional:

../../node/deps/simdjson/simdjson.cpp:16357:10: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
 16357 |   return nullptr;
       |          ^~~~~~~

  /* can't be reached */
  return nullptr;
}

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55963/

[aduh95]

This touches code from our deps, it should land there first otherwise it's going to be overwritten by the next update.

[targos]

These .gni files are not part of the deps. They are kept by the deps_updaters scripts

[lemire]

@anonrig Correct. Let us fix these issues upstream.

[lemire]

@anonrig Bumping simdjson to 3.6.1 should help https://github.com/simdjson/simdjson/releases/tag/v3.6.1

[anonrig]

Thanks @lemire, I'll trigger the update script.

[lemire]

@anonrig Bumping simdutf to 4.0.6 should help as well https://github.com/simdutf/simdutf/releases/tag/v4.0.6

[zcbenz]

@lemire Thank you so much! I confirm the warnings have been fixed with simdutf 4.0.6 and simdjson 3.6.1.

[zcbenz]

@lemire There are actually a few other warnings disabled when compiling simdutf, I'm pasting them here for your reference:

-Wc++98-compat-extra-semi

../../node/deps/simdutf/simdutf.cpp:5698:83: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
 5698 |   simdutf_really_inline result::result() : error{error_code::SUCCESS}, count{0} {};
      |                                                                                   ^
../../node/deps/simdutf/simdutf.cpp:5700:99: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
 5700 |   simdutf_really_inline result::result(error_code _err, size_t _pos) : error{_err}, count{_pos} {};
      |                                                                                                   ^
../../node/deps/simdutf/simdutf.cpp:26136:4: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
 26136 |   }; 
       |    ^
../../node/deps/simdutf/simdutf.cpp:28472:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
 28472 | };
       |  ^
../../node/deps/simdutf/simdutf.cpp:28486:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
 28486 | };
       |  ^
../../node/deps/simdutf/simdutf.cpp:29047:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
 29047 | };
       |  ^
../../node/deps/simdutf/simdutf.cpp:32513:4: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
 32513 |   }; 
       |    ^
7 errors generated.

-Wunreachable-code-break

../../node/deps/simdutf/simdutf.cpp:20732:9: error: 'break' will never be executed [-Werror,-Wunreachable-code-break]
 20732 |         break;
       |         ^~~~~

[lemire]

There will be another simdutf patch release.

simdutf/simdutf#356

[lemire]

@anonrig New patch release with a few more fixes https://github.com/simdutf/simdutf/releases/tag/v4.0.7