Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
esm
anonrig
approved these changes
Nov 24, 2023
H4ad
approved these changes
Nov 26, 2023
H4ad
added
the
author ready
anonrig
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/50887 ✔ Done loading data for nodejs/node/pull/50887 ----------------------------------- PR info ------------------------------------ Title esm: improve hook type (#50887) Author Alex Yang (@himself65) Branch himself65:himself65/type-improve -> nodejs:main Labels esm, author ready, typings Commits 1 - esm: improve hook type Committers 1 - Alex Yang PR-URL: https://github.com/nodejs/node/pull/50887 Reviewed-By: Yagiz Nizipli Reviewed-By: Vinícius Lourenço Claro Cardoso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50887 Reviewed-By: Yagiz Nizipli Reviewed-By: Vinícius Lourenço Claro Cardoso -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 23 Nov 2023 21:41:02 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50887#pullrequestreview-1747908415 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50887#pullrequestreview-1749354252 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6996369243 |
anonrig
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
github-actions
bot
removed
the
request-ci
Collaborator
github-actions
bot
removed
the
request-ci
This comment was marked as off-topic.
This comment was marked as off-topic.
JakobJingleheimer
approved these changes
Nov 27, 2023
Member
JakobJingleheimer
left a comment
JakobJingleheimer
left a comment
There was a problem hiding this comment.
Took me a minute to trace these, but you're right! Thanks for the catch 🙂
Contributor
|
Landed in 2793e8b |
targos
pushed a commit
that referenced
this pull request
Dec 4, 2023
PR-URL: #50887 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Jacob Smith <jacob@frende.me>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #50887 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Jacob Smith <jacob@frende.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.