Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add workflow to update release links #50710

Merged
merged 1 commit into from
Nov 15, 2023
Merged

tools: add workflow to update release links #50710

merged 1 commit into from
Nov 15, 2023

Conversation

targos
Copy link
Member

@targos targos commented Nov 13, 2023

Refs: #50623

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 13, 2023
@targos targos mentioned this pull request Nov 13, 2023
Closed
@targos
Copy link
Member Author

targos commented Nov 13, 2023

/cc @nodejs/tsc. I think this requires adding write access to https://github.com/nodejs/release-cloudflare-worker for the nodejs-github-bot account.

ovflowd
ovflowd approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is awesome! That's an interesting way of triggering the Workflow by using GitHub's CLI!

.github/workflows/update-release-links.yml
steps:
- name: Trigger update-links workflow on nodejs/release-cloudflare-worker
run: |
gh workflow run update-links.yml --repo nodejs/release-cloudflare-worker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also trigger the job (after this one) to deploy the worker to prod 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you want this to happen, it should be done from the nodejs/release-cloudflare-worker repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, was pondering on that. @flakey5 it might make sense to make it autodeploz after updating the links

Copy link
Member

@MoLow MoLow Nov 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it currently opens a PR and needs manual approval & merge - we will need to change it to commit and push to main - I don't know if that is possible

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it currently opens a PR and needs manual approval & merge - we will need to change it to commit and push to main - I don't know if that is possible

It is. You can make the workflow commit and push to main directly,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd definitely be for either letting the releasers merge the pr it generates in release-cloudflare-worker or having them automatically merged and then deployed. I'm not sure exactly how we could get the second option working right now though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is easy to do the 2nd. Just instead of opening a PR simply do a commit and then push. You can see a workflow that does similar on the nodejs.org repository (I think the i18n workflow)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that sounds good to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create an issue on the worker repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs/release-cloudflare-worker#66

mhdawson
mhdawson approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flakey5 flakey5 mentioned this pull request Nov 14, 2023
Closed
@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2023
@nodejs-github-bot nodejs-github-bot merged commit 86593e5 into nodejs:main Nov 15, 2023
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 86593e5

@targos targos deleted the update-links branch November 15, 2023 13:40
targos added a commit that referenced this pull request Nov 23, 2023
@targos
tools: add workflow to update release links
52830b7 
Refs: #50623
PR-URL: #50710
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@targos @martenrichter
tools: add workflow to update release links
d7223b6 
Refs: nodejs#50623
PR-URL: nodejs#50710
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@targos @UlisesGascon
tools: add workflow to update release links
6beb18b 
Refs: #50623
PR-URL: #50710
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@targos @UlisesGascon
tools: add workflow to update release links
93085cf 
Refs: #50623
PR-URL: #50710
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flakey5 flakey5 flakey5 left review comments

@ovflowd ovflowd ovflowd approved these changes

@MoLow MoLow MoLow approved these changes

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@targos @nodejs-github-bot @jasnell @anonrig @UlisesGascon @richardlau @MoLow @mhdawson @ovflowd @flakey5