Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: pass abortSignal to test files #50630

Merged
merged 1 commit into from
Nov 10, 2023
Merged

test_runner: pass abortSignal to test files #50630

merged 1 commit into from
Nov 10, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Nov 8, 2023

Fixes: #50583

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Nov 8, 2023
@debadree25 debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55508/

@atlowChemi atlowChemi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 9, 2023
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3cce03a into nodejs:main Nov 10, 2023
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3cce03a

targos pushed a commit that referenced this pull request Nov 11, 2023
@MoLow @targos
test_runner: pass abortSignal to test files
73d13b8 
PR-URL: #50630
Fixes: #50583
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MoLow MoLow deleted the pass-abort-signal branch November 12, 2023 07:14
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@MoLow @targos
test_runner: pass abortSignal to test files
01bed64 
PR-URL: #50630
Fixes: #50583
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@MoLow @UlisesGascon
test_runner: pass abortSignal to test files
2c72ed8 
PR-URL: #50630
Fixes: #50583
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@debadree25 debadree25 debadree25 approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node:test run does not respect abort signal
5 participants
@MoLow @nodejs-github-bot @benjamingr @debadree25 @atlowChemi