tools: add macOS notarization verification step#50628
Closed
UlisesGascon wants to merge 2 commits intonodejs:mainfrom
Closed
tools: add macOS notarization verification step#50628UlisesGascon wants to merge 2 commits intonodejs:mainfrom
UlisesGascon wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
20 tasks
Collaborator
tony-go
approved these changes
Nov 9, 2023
This was referenced Nov 10, 2023
Member
|
@UlisesGascon looks like this needs a rebase |
Member
Author
Thanks @mhdawson! I was able to solve the conflict directly in the Github UI as it was a simple change. Let me know if this require additional work to be done with the git history :) |
Member
|
@UlisesGascon for some reason git-node still can't land it. Can you rebase into a single commit ? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Changes
Add a verification step to validate the notarized binaries generated for macOS.
cc: @nodejs/build @nodejs/releasers
Context
Another PR related is #50625
You can find more information in this amazing article https://tonygo.ghost.io/notarization-for-macos-app-with-notarytool/ by @tony-go
Test
This was tested in
iojs+release-ulises-experimentalpipeline in jenkins ci release.case: error
The error was "simulated" by using a different type
Full log available here
case: success
Full log available here