Skip to content

Conversation

@Ranieri93
Copy link
Contributor

Hi Folks!
This PR is linked to this issue

Love NodeConf!! ♥️

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 7, 2023
@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
@ShogunPanda ShogunPanda added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

Fast-track has been requested by @ShogunPanda. Please 👍 to approve.

@RafaelGSS RafaelGSS changed the title Update Permission Model documentation to include resource field doc: update pm documentation to include resource field Nov 7, 2023
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

changes

Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Nov 7, 2023
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 4d6c8a0 into nodejs:main Nov 8, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 4d6c8a0

targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #50601
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
targos pushed a commit that referenced this pull request Nov 14, 2023
PR-URL: #50601
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #50601
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants