Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix reference to API hash.final #5050

Closed
wants to merge 1 commit into from
Closed

doc: fix reference to API hash.final #5050

wants to merge 1 commit into from

Conversation

JungMinu
Copy link
Member

@JungMinu JungMinu commented Feb 3, 2016

fix a reference to a non-existent API, hash.final().
It should be hash.digest().

@JungMinu JungMinu added the doc Issues and PRs related to the documentations. label Feb 3, 2016
@JungMinu JungMinu self-assigned this Feb 3, 2016
@stevemao
Copy link
Contributor

stevemao commented Feb 3, 2016

LGTM

@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Feb 3, 2016
@jasnell
Copy link
Member

jasnell commented Feb 3, 2016

LGTM

2 similar comments
@evanlucas
Copy link
Contributor

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Feb 3, 2016

LGTM

fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: #5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
JungMinu added a commit that referenced this pull request Feb 4, 2016
fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: #5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@JungMinu
Copy link
Member Author

JungMinu commented Feb 4, 2016

Thanks, landed in 34a5019

@JungMinu JungMinu closed this Feb 4, 2016
@JungMinu JungMinu deleted the doc-api branch February 4, 2016 13:20
rvagg pushed a commit that referenced this pull request Feb 8, 2016
fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: #5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: #5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: #5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: #5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
fix a reference to a non-existent API, `hash.final()`.
It should be `hash.digest()`.

PR-URL: nodejs#5050
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants