stream: fix Writable.destroy performance regression#50478
Merged
Trott merged 1 commit intonodejs:mainfrom Oct 31, 2023
Merged
Conversation
Collaborator
|
Review requested:
|
Member
Author
|
This PR is here just to run the |
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
H4ad
approved these changes
Oct 31, 2023
Collaborator
Collaborator
Collaborator
Trott
added
the
author ready
Member
Author
|
This is ready to land but needs one more approval. |
ronag
previously approved these changes
Oct 31, 2023
ronag
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/50478 ✔ Done loading data for nodejs/node/pull/50478 ----------------------------------- PR info ------------------------------------ Title stream: fix Writable.destroy performance regression (#50478) Author Rich Trott (@Trott) Branch Trott:test-pr -> nodejs:main Labels fast-track, author ready, needs-ci Commits 1 - stream: fix Writable.destroy performance regression Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/50478 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Robert Nagy ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50478 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Robert Nagy -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 30 Oct 2023 20:10:40 GMT ✔ Approvals: 2 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50478#pullrequestreview-1705323018 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/50478#pullrequestreview-1707190813 ℹ This PR is being fast-tracked ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-10-31T18:59:52Z: https://ci.nodejs.org/job/node-test-pull-request/55362/ - Querying data for job/node-test-pull-request/55362/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6712160359 |
Trott
dismissed
ronag’s stale review
I'm going to dismiss this one because it's the commit author.
aduh95
approved these changes
Oct 31, 2023
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
I miss a bit of context on how this is perf related, but the change looks fine to me
Ref: nodejs#50409 PR-URL: nodejs#50478 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Member
Author
|
Landed in c4decd7 |
24 tasks
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Ref: nodejs#50409 PR-URL: nodejs#50478 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Nov 2, 2023
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Nov 9, 2023
Ref: nodejs#50409 PR-URL: nodejs#50478 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #50409