Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix vm assertion actual and expected order #50371

Merged
merged 1 commit into from
Oct 26, 2023
+3 −3
Merged

test: fix vm assertion actual and expected order #50371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/parallel/test-vm-module-dynamic-import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ async function test() {
});

const result = s.runInThisContext();
assert.strictEqual(foo.namespace, await result);
assert.strictEqual(await result, foo.namespace);
}

{
Expand All @@ -53,7 +53,7 @@ async function test() {
});
await m.link(common.mustNotCall());
await m.evaluate();
assert.strictEqual(foo.namespace, await globalThis.fooResult);
assert.strictEqual(await globalThis.fooResult, foo.namespace);
delete globalThis.fooResult;
}

Expand All @@ -68,7 +68,7 @@ async function test() {
});

const result = s.runInThisContext();
assert.strictEqual(foo.namespace, await result);
assert.strictEqual(await result, foo.namespace);
}
}

Expand Down