cluster: replace forEach with for..of in lib/internal/cluster/ directory#50317
Merged
aduh95 merged 5 commits intonodejs:mainfrom May 12, 2024
Merged
cluster: replace forEach with for..of in lib/internal/cluster/ directory#50317aduh95 merged 5 commits intonodejs:mainfrom
aduh95 merged 5 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
cluster
|
Out of curiosity why this change? |
Contributor
Author
Coding style consistency. |
jasnell
approved these changes
Oct 28, 2023
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
aduh95
force-pushed
the
foreach2for-cluster
branch
from
c348acb to
92a9ea3
Compare
aduh95
requested changes
May 11, 2024
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
approved these changes
May 11, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
aduh95
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/50317 ✔ Done loading data for nodejs/node/pull/50317 ----------------------------------- PR info ------------------------------------ Title cluster: replace forEach with for..of in lib/internal/cluster/ directory (#50317) Author Jérôme Benoit (@jerome-benoit, first-time contributor) Branch jerome-benoit:foreach2for-cluster -> nodejs:main Labels cluster, author ready, needs-ci, commit-queue-squash Commits 5 - cluster: replace forEach with for..of in lib/internal/cluster/ directory - refactor: silence linter - build: silence linter - fix: handles in a SafeMap - Update lib/internal/cluster/primary.js Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/50317 Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50317 Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 21 Oct 2023 16:56:59 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50317#pullrequestreview-1702814874 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/50317#pullrequestreview-2051249874 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-05-12T07:22:07Z: https://ci.nodejs.org/job/node-test-pull-request/59150/ - Querying data for job/node-test-pull-request/59150/ ✔ Last Jenkins CI successful ⚠ PR author is a new contributor: @jerome-benoit(jerome.benoit@piment-noir.org) ⚠ - commit 001629ef3769 is authored by jerome.benoit@sap.com ⚠ - commit 3deccf496fcb is authored by jerome.benoit@sap.com ⚠ - commit 0b1f164bdc43 is authored by jerome.benoit@sap.com ⚠ - commit 92a9ea30040f is authored by jerome.benoit@sap.com -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9053086020 |
Contributor
|
Landed in 7b2dc79 |
targos
pushed a commit
that referenced
this pull request
May 12, 2024
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com> PR-URL: #50317 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com> PR-URL: #50317 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com> PR-URL: #50317 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 17, 2024
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com> PR-URL: #50317 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com> PR-URL: nodejs#50317 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com> PR-URL: nodejs#50317 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.