Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x] doc: fix globalPreload example #50300

Closed
wants to merge 1 commit into from
Closed

[v18.x] doc: fix globalPreload example #50300

wants to merge 1 commit into from

Conversation

bmacnaughton
Copy link
Contributor

@bmacnaughton bmacnaughton commented Oct 19, 2023 •
edited
Loading

module: correct the documentation for globalPreload

fixes: #50279

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Oct 19, 2023
@aduh95 aduh95 changed the title update port example [v18.x] doc: fix globalPreload example Oct 20, 2023
@H4ad H4ad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 20, 2023
@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 22, 2023
@targos
Copy link
Member

targos commented Oct 28, 2023

Landed in 2b30c8b

targos pushed a commit that referenced this pull request Oct 28, 2023
@bmacnaughton @targos
doc: fix globalPreload example
2b30c8b 
Fixes: #50279
PR-URL: #50300
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@targos targos closed this Oct 28, 2023
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: fix globalPreload example
9e5d891 
Fixes: nodejs/node#50279
PR-URL: nodejs/node#50300
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: fix globalPreload example
f7148ec 
Fixes: nodejs/node#50279
PR-URL: nodejs/node#50300
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@aduh95 aduh95 aduh95 approved these changes

@aymen94 aymen94 aymen94 approved these changes

@H4ad H4ad H4ad approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bmacnaughton @nodejs-github-bot @targos @H4ad @aymen94 @aduh95 @marco-ippolito