-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: move Trott to TSC regular member #50297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years.
Fast-track has been requested by @Trott. Please 👍 to approve. |
bnb
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appreciate the work you've done in the role, Rich - thank you ❤️
richardlau
approved these changes
Oct 19, 2023
Trott
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 19, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 19, 2023
Landed in b30acb7 |
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years. PR-URL: #50297 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com>
I am late to the party, just want to show my appreciation of all the work you've been doing for the project over the years ❤️ |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years. PR-URL: nodejs#50297 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years. PR-URL: #50297 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years. PR-URL: #50297 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com>
mertcanaltin
pushed a commit
to mertcanaltin/node
that referenced
this pull request
Dec 19, 2023
PR-URL: nodejs#50261 Refs: nodejs#50260 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> meta: move Trott to TSC regular member At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years. PR-URL: nodejs#50297 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com> node-api: refactor napi set property function for improved performance fix: lint fix: lint refactor: Improve performance by using internalized property keys refactor: Update node_api_create_property_key_utf16 signature and remove napi_set_property_utf16 lint lint fix: Resolve compilation error in node_api_create_property_key_utf16 fix: Resolve type conversion error in node_api_create_property_key_utf16 refactor: Simplify node_api_create_property_key_utf16 implementation lint add node_api_create_property_key_utf16 property name added doc for node_api_create_property_key_utf16 lint lint update napi doc for node_api_create_property_key_utf16 update: code snipet test: added test for node_api_create_property_key_utf16 lint lint lint call node_api_create_property_key_utf16 Update doc/api/n-api.md Co-authored-by: Chengzhong Wu <legendecas@gmail.com> Update test/js-native-api/test_string/test_string.c Co-authored-by: Chengzhong Wu <legendecas@gmail.com> Update test/js-native-api/test_string/test_string.c Co-authored-by: Chengzhong Wu <legendecas@gmail.com> Update doc/api/n-api.md Co-authored-by: Chengzhong Wu <legendecas@gmail.com> added TestPropertyKeyUtf16 napi_property_descriptor lint doc lint cpp minor updates to PR nodejs#50282 feat: removed not used function for test Update doc/api/n-api.md Co-authored-by: Michael Dawson <mdawson@devrus.com> Update doc/api/n-api.md Co-authored-by: Michael Dawson <mdawson@devrus.com>
mertcanaltin
pushed a commit
to mertcanaltin/node
that referenced
this pull request
Dec 19, 2023
PR-URL: nodejs#50261 Refs: nodejs#50260 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> meta: move Trott to TSC regular member At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years. PR-URL: nodejs#50297 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com> node-api: refactor napi set property function for improved performance fix: lint fix: lint refactor: Improve performance by using internalized property keys refactor: Update node_api_create_property_key_utf16 signature and remove napi_set_property_utf16 lint lint fix: Resolve compilation error in node_api_create_property_key_utf16 fix: Resolve type conversion error in node_api_create_property_key_utf16 refactor: Simplify node_api_create_property_key_utf16 implementation lint add node_api_create_property_key_utf16 property name added doc for node_api_create_property_key_utf16 lint lint update napi doc for node_api_create_property_key_utf16 update: code snipet test: added test for node_api_create_property_key_utf16 lint lint lint call node_api_create_property_key_utf16 Update doc/api/n-api.md Co-authored-by: Chengzhong Wu <legendecas@gmail.com> Update test/js-native-api/test_string/test_string.c Co-authored-by: Chengzhong Wu <legendecas@gmail.com> Update test/js-native-api/test_string/test_string.c Co-authored-by: Chengzhong Wu <legendecas@gmail.com> Update doc/api/n-api.md Co-authored-by: Chengzhong Wu <legendecas@gmail.com> added TestPropertyKeyUtf16 napi_property_descriptor lint doc lint cpp minor updates to PR nodejs#50282 feat: removed not used function for test Update doc/api/n-api.md Co-authored-by: Michael Dawson <mdawson@devrus.com> Update doc/api/n-api.md Co-authored-by: Michael Dawson <mdawson@devrus.com>
mertcanaltin
pushed a commit
to mertcanaltin/node
that referenced
this pull request
Dec 19, 2023
PR-URL: nodejs#50261 Refs: nodejs#50260 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> meta: move Trott to TSC regular member At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years. PR-URL: nodejs#50297 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com> node-api: refactor napi set property function for improved performance fix: lint fix: lint refactor: Improve performance by using internalized property keys refactor: Update node_api_create_property_key_utf16 signature and remove napi_set_property_utf16 lint lint fix: Resolve compilation error in node_api_create_property_key_utf16 fix: Resolve type conversion error in node_api_create_property_key_utf16 refactor: Simplify node_api_create_property_key_utf16 implementation lint add node_api_create_property_key_utf16 property name added doc for node_api_create_property_key_utf16 lint lint update napi doc for node_api_create_property_key_utf16 update: code snipet test: added test for node_api_create_property_key_utf16 lint lint lint call node_api_create_property_key_utf16 Update doc/api/n-api.md Co-authored-by: Chengzhong Wu <legendecas@gmail.com> Update test/js-native-api/test_string/test_string.c Co-authored-by: Chengzhong Wu <legendecas@gmail.com> Update test/js-native-api/test_string/test_string.c Co-authored-by: Chengzhong Wu <legendecas@gmail.com> Update doc/api/n-api.md Co-authored-by: Chengzhong Wu <legendecas@gmail.com> added TestPropertyKeyUtf16 napi_property_descriptor lint doc lint cpp minor updates to PR nodejs#50282 feat: removed not used function for test Update doc/api/n-api.md Co-authored-by: Michael Dawson <mdawson@devrus.com> Update doc/api/n-api.md Co-authored-by: Michael Dawson <mdawson@devrus.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years. PR-URL: nodejs/node#50297 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years. PR-URL: nodejs/node#50297 Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the current time, I'm not able to give Node.js the time and attention it needs and deserves from a voting TSC member. I'm proud of the work and efforts I've made as a TSC voting member, and I want to leave before I'm less happy with my efforts. Thanks for all the trust and good will over the years.