Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove no-return-await lint rule #50118

Merged

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Oct 10, 2023

no-return-await rule was deprecated in ESLint 8.46.0. According to the ESLint docs removing await can make the code slower.

Refs: https://eslint.org/docs/latest/rules/no-return-await

This rule was added in #17265.
return await is sometimes necessary to create a better stacktrace (#49849 (comment)).

no-return-await rule was deprecated in ESLint 8.46.0. According to the
ESLint docs removing `await` can make the code slower.

Refs: https://eslint.org/docs/latest/rules/no-return-await
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 10, 2023
@sapphi-red sapphi-red force-pushed the tools/remove-no-return-await-rule branch from a503145 to 0d4caee Compare October 10, 2023 10:38
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2023
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2023
@nodejs-github-bot nodejs-github-bot merged commit 760b5dd into nodejs:main Oct 12, 2023
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 760b5dd

@sapphi-red sapphi-red deleted the tools/remove-no-return-await-rule branch October 12, 2023 11:30
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
no-return-await rule was deprecated in ESLint 8.46.0. According to the
ESLint docs removing `await` can make the code slower.

Refs: https://eslint.org/docs/latest/rules/no-return-await
PR-URL: nodejs#50118
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
no-return-await rule was deprecated in ESLint 8.46.0. According to the
ESLint docs removing `await` can make the code slower.

Refs: https://eslint.org/docs/latest/rules/no-return-await
PR-URL: #50118
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants