Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: add flush option to createWriteStream() #50093

Merged
merged 4 commits into from
Oct 11, 2023
Merged

fs: add flush option to createWriteStream() #50093

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95284fb
fs: add flush option to createWriteStream()
cjihrig Oct 8, 2023
999a048
nits
cjihrig Oct 8, 2023
345bcca
nit
cjihrig Oct 8, 2023
ff247df
linter
cjihrig Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit
  • Loading branch information
@cjihrig
cjihrig committed Oct 8, 2023
commit 345bcca9150b611907da1fb8d85949fa59c4a5a2
1 change: 0 additions & 1 deletion lib/internal/fs/streams.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@ function WriteStream(path, options) {
validateFunction(this[kFs].fsync, 'options.fs.fsync');
}


// It's enough to override either, in which case only one will be used.
if (!this[kFs].write) {
this._write = null;
Expand Down