Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: reserve 119 for Electron 28 #50020

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

dsanders11
Copy link
Contributor

This PR reserves NMV 119 for Electron 28.

Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 3, 2023
@dsanders11
Copy link
Contributor Author

Not sure if this will interfere with #49870, but happy to tweak it as needed.

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2023
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Fast-track has been requested by @targos. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2023
@nodejs-github-bot nodejs-github-bot merged commit f3ed57b into nodejs:main Oct 3, 2023
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f3ed57b

@dsanders11 dsanders11 deleted the nmv-electron-28 branch October 3, 2023 16:22
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
PR-URL: nodejs#50020
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
PR-URL: #50020
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Nov 27, 2023
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
PR-URL: nodejs#50020
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants