-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: reserve 119 for Electron 28 #50020
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
Not sure if this will interfere with #49870, but happy to tweak it as needed. |
targos
approved these changes
Oct 3, 2023
MoLow
approved these changes
Oct 3, 2023
anonrig
approved these changes
Oct 3, 2023
richardlau
approved these changes
Oct 3, 2023
richardlau
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 3, 2023
Fast-track has been requested by @targos. Please 👍 to approve. |
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Oct 3, 2023
Landed in f3ed57b |
1 task
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Signed-off-by: David Sanders <dsanders11@ucsbalum.com> PR-URL: nodejs#50020 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
Signed-off-by: David Sanders <dsanders11@ucsbalum.com> PR-URL: #50020 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
added
the
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
label
Nov 27, 2023
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
Signed-off-by: David Sanders <dsanders11@ucsbalum.com> PR-URL: nodejs#50020 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reserves NMV 119 for Electron 28.