Skip to content

streams: use private symbol for bitmap state #49993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2023
Merged

streams: use private symbol for bitmap state #49993

merged 1 commit into from
Oct 14, 2023

Conversation

@ronag
Copy link
Member

@ronag ronag commented Oct 1, 2023

No description provided.

@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Oct 1, 2023
@ronag ronag requested review from benjamingr and mcollina October 1, 2023 11:50
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 1, 2023

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 1, 2023
benjamingr
benjamingr approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with benchmark

@ronag
Copy link
Member Author

ronag commented Oct 1, 2023

https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1431/

ronag added a commit to nxtedition/node that referenced this pull request Oct 1, 2023
@ronag
streams: use private symbol for bitmap state
c875109 
PR-URL: nodejs#49993
mcollina
mcollina approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benjamingr benjamingr added the needs-benchmark-ci PR that need a benchmark CI run. label Oct 1, 2023
ronag added a commit to nxtedition/node that referenced this pull request Oct 1, 2023
@ronag
streams: use private symbol for bitmap state
3b0927d 
PR-URL: nodejs#49993
ronag added a commit to nxtedition/node that referenced this pull request Oct 1, 2023
@ronag
streams: use private symbol for bitmap state
eedb2d8 
PR-URL: nodejs#49993
ronag added a commit to nxtedition/node that referenced this pull request Oct 1, 2023
@ronag
stream: use private symbol for bitmap state
a0231fe 
PR-URL: nodejs#49993
ronag added a commit to nxtedition/node that referenced this pull request Oct 2, 2023
@ronag
stream: use private symbol for bitmap state
ec7a8cd 
PR-URL: nodejs#49993
ronag added a commit to nxtedition/node that referenced this pull request Oct 9, 2023
@ronag
streams: use private symbol for bitmap state
37cfe4c 
PR-URL: nodejs#49993
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Uzlopak
Uzlopak approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 10, 2023
Open
24 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Open
30 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 14, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/54781/

@Trott
Copy link
Member

Trott commented Oct 14, 2023

The AIX CI passed, but the widget says it failed. 🤷 I'll land this manually.

@Trott Trott merged commit aad8002 into nodejs:main Oct 14, 2023
@Trott
Copy link
Member

Trott commented Oct 14, 2023

Landed in aad8002

@RafaelGSS RafaelGSS mentioned this pull request Oct 15, 2023
Merged
kumarrishav pushed a commit to kumarrishav/node that referenced this pull request Oct 16, 2023
@ronag @kumarrishav
stream: use private symbol for bitmap state
7b1e5b4 
PR-URL: nodejs#49993
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@ronag @alexfernandez
stream: use private symbol for bitmap state
eb159d8 
PR-URL: nodejs#49993
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@ronag @targos
stream: use private symbol for bitmap state
e60b3ab 
PR-URL: #49993
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

@anonrig anonrig anonrig approved these changes

@rluvaton rluvaton rluvaton approved these changes

+1 more reviewer

@Uzlopak Uzlopak Uzlopak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ronag @nodejs-github-bot @Trott @mcollina @benjamingr @anonrig @Uzlopak @rluvaton