Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace forEach with for..of in test-http-url #49840

Closed
wants to merge 2 commits into from

Conversation

niyashiyas
Copy link
Contributor

Replaced forEach with for in test-http-url.parse-only-support-http-https-protocol.js

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 24, 2023
@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 24, 2023
@benjamingr
Copy link
Member

Hi @niyashiyas note that code and learn issues are usually preferably "one or a few per participant", you've opened 23. I thank you for your help and appreciate your enthusiasm but think it would be preferable to focus on addressing the issues on your other PRs until they land.

@benjamingr
Copy link
Member

To explain these are issues/ideas specifically picked in order to get someone acquainted with the process of contributing to Node.js.

Each one you make creates work for project members who need to view the code, run benchmarks and track it.

@niyashiyas niyashiyas changed the title test: replaced forEach with for..of in test-http-url test: replace forEach with for..of in test-http-url Sep 30, 2023
@lpinca lpinca added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/49840
✔  Done loading data for nodejs/node/pull/49840
----------------------------------- PR info ------------------------------------
Title      test: replace forEach with for..of in test-http-url (#49840)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     niyashiyas:test-10 -> nodejs:main
Labels     test, code-and-learn, needs-ci, commit-queue-squash
Commits    2
 - test: replace forEach with for..of in test-http-url
 - test: replace forEach with for..of in test-http-url
Committers 1
 - Niya Shiyas 
PR-URL: https://github.com/nodejs/node/pull/49840
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49840
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 24 Sep 2023 10:12:56 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49840#pullrequestreview-1662401958
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-10-07T05:17:43Z: https://ci.nodejs.org/job/node-test-pull-request/54592/
- Querying data for job/node-test-pull-request/54592/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6440454179

lpinca pushed a commit that referenced this pull request Oct 7, 2023
PR-URL: #49840
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca
Copy link
Member

lpinca commented Oct 7, 2023

Landed in 2449247.

@lpinca lpinca closed this Oct 7, 2023
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#49840
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #49840
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
PR-URL: nodejs#49840
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants