test: Refactor ForEach and destructure the code#49768
test: Refactor ForEach and destructure the code#49768codie-bee wants to merge 1 commit intonodejs:mainfrom
Conversation
|
The change looks good to me. The commit message lines will need to be 72 characters or less though. You can see the commit message guidelines here: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines |
Thanks, updated the commit description |
|
You will have to push your changes too. Generally to update the commit message you would run |
dce8817 to
b2a98b1
Compare
RafaelGSS
left a comment
There was a problem hiding this comment.
@codie-bee Thanks for the contribution! FYI, the commit email address is not associated with your GitHub account. You can either add the commit email address to your GitHub account, or change your commit email address to your GitHub-associated email address.
b2a98b1 to
107bb18
Compare
Thanks @RafaelGSS! I have changed my commit email address. |
d62fb36 to
a48f610
Compare
RafaelGSS
left a comment
There was a problem hiding this comment.
Almost done! @codie-bee see https://github.com/nodejs/node/actions/runs/6302781305/job/17118196491?pr=49768
You need to adjust the commit message to
- test: Refactor ForEach and destructure the code
+ test: refactor ForEach and destructure the code|
We are closing it because we have not received any updates after requesting the change. |
test: Refactor ForEach and destructure the code