-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-api: treat V8 platform symbols same as base #49740
base: main
Are you sure you want to change the base?
Conversation
Export V8 platform symbols in the Node shared library build, in the same way as with V8 base, to allow linking on Windows. PR-URL: nodejs#49596
Review requested:
|
This PR replaces #49596. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you please rebase on top of |
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
I believe the changes have now been rebased onto main |
Export V8 platform symbols in the Node shared library build, in the same way as with V8 base, to allow linking on Windows.
PR-URL: #49596