Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: backport --predictable related changes to V8 #49703

Closed
wants to merge 2 commits into from
Closed

deps: backport --predictable related changes to V8 #49703

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f4e632
deps: V8: cherry-pick b33bf2dfd261
joyeecheung Jul 20, 2023
308af9f
deps: V8: backport de9a5de2274f
joyeecheung Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
deps: V8: cherry-pick b33bf2dfd261 
Original commit message:

    Ignore --predictable when computing flag list hashes

    This allows reproducible code cache generation.

    Refs: #48749

    Change-Id: Ib4693de60ddff1fe41d95c10980f763463db3f95
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4681766
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#88943}

Refs: v8/v8@b33bf2d
  • Loading branch information
@joyeecheung
joyeecheung committed Sep 18, 2023
commit 8f4e63295e27e24711f52f96be794a5354175468
4 changes: 3 additions & 1 deletion deps/v8/src/flags/flags.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,8 +539,10 @@ uint32_t ComputeFlagListHash() {
// We want to be able to flip --profile-deserialization without
// causing the code cache to get invalidated by this hash.
if (flag.PointsTo(&v8_flags.profile_deserialization)) continue;
// Skip v8_flags.random_seed to allow predictable code caching.
// Skip v8_flags.random_seed and v8_flags.predictable to allow predictable
// code caching.
if (flag.PointsTo(&v8_flags.random_seed)) continue;
if (flag.PointsTo(&v8_flags.predictable)) continue;
modified_args_as_string << flag;
}
std::string args(modified_args_as_string.str());
Expand Down