fs: fix readdir and opendir recursive with unknown file types #49603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
If the libuv operations invoked by `readdir`/`opendir` return `uv_dirent_t` values where the `type` is `UV_DIRENT_UNKNOWN` then a further `lstat` is issued to fully construct the `Dirent` values. In the recursive versions of these functions, the `path` parameter was incorrectly assumed to be the path to the entry when it should be the path to the directory containing the entry. Fixes #49499.
github-actions
bot
removed
the
request-ci
|
Great investigation and fix @lux01 . Thank you very much! |
MoLow
approved these changes
Sep 11, 2023
|
@ruyadorno this seems like a serious bug and is ready for landing, perhaps it is a good idea to land this into v18? |
MoLow
added
fast-track
|
Fast-track has been requested by @MoLow. Please 👍 to approve. |
|
To fix this on the |
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d8b378c |
|
@MoLow it hasn't landed on time yet for the v20 release and I prefer not to rush it to v18 before it's out in a current release line. 😊 thanks for the heads up though! |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
If the libuv operations invoked by `readdir`/`opendir` return `uv_dirent_t` values where the `type` is `UV_DIRENT_UNKNOWN` then a further `lstat` is issued to fully construct the `Dirent` values. In the recursive versions of these functions, the `path` parameter was incorrectly assumed to be the path to the entry when it should be the path to the directory containing the entry. Fixes #49499. PR-URL: #49603 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
If the libuv operations invoked by `readdir`/`opendir` return `uv_dirent_t` values where the `type` is `UV_DIRENT_UNKNOWN` then a further `lstat` is issued to fully construct the `Dirent` values. In the recursive versions of these functions, the `path` parameter was incorrectly assumed to be the path to the entry when it should be the path to the directory containing the entry. Fixes nodejs#49499. PR-URL: nodejs#49603 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95
added
the
dont-land-on-v18.x
|
This introduced a breaking change for |
sonsurim
pushed a commit
to sonsurim/node
that referenced
this pull request
Jul 21, 2024
An error occurred in the test/sequential/test-fs-opendir-recursive.js file after changing the code. This was resolved by referring to the code resolved in PR nodejs#49603. Refs: nodejs#49603
sonsurim
pushed a commit
to sonsurim/node
that referenced
this pull request
Jul 21, 2024
An error occurred in the test/sequential/test-fs-opendir-recursive.js file after changing the code. This was resolved by referring to the code resolved in PR nodejs#49603. Refs: nodejs#49603
sonsurim
pushed a commit
to sonsurim/node
that referenced
this pull request
Jul 21, 2024
An error occurred in the test/sequential/test-fs-opendir-recursive.js file after changing the code. This was resolved by referring to the code resolved in PR nodejs#49603. Refs: nodejs#49603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the libuv operations invoked by
readdir/opendirreturnuv_dirent_tvalues where thetypeisUV_DIRENT_UNKNOWNthen a furtherlstatis issued to fully construct theDirentvalues. In the recursive versions of these functions, thepathparameter was incorrectly assumed to be the path to the entry when it should be the path to the directory containing the entry.Fixes #49499.