Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: validate list elements in Buffer.concat #4951

Merged
merged 1 commit into from
Jan 31, 2016
Merged

buffer: validate list elements in Buffer.concat #4951

merged 1 commit into from
Jan 31, 2016

Commits on Jan 31, 2016

  1. buffer: validate list elements in Buffer.concat 

    Without this change, if any of the elements in the list to be concatenated is
not a Buffer instance, the method fails with "buf.copy is not a function".
Make an isBuffer check before using the copy method so that we can throw with
a better message.

Fixes: nodejs#4949
PR-URL: nodejs#4951
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
    @targos
    targos committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    d2dc234 View commit details
    Browse the repository at this point in the history