dgram: scope redeclared variables #4940
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM |
A few variables in `lib/dgram.js` are redeclared with `var` in a scope where they have already been declared. These instances can be scoped more narrowly with `const`, so that's what this change does.
Trott
force-pushed
the
dgram-no-redeclare
branch
from
de3c655 to
727d89b
Compare
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 31, 2016
A few variables in `lib/dgram.js` are redeclared with `var` in a scope where they have already been declared. These instances can be scoped more narrowly with `const`, so that's what this change does. PR-URL: nodejs#4940 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 1800bf4 |
rvagg
pushed a commit
that referenced
this pull request
Feb 10, 2016
A few variables in `lib/dgram.js` are redeclared with `var` in a scope where they have already been declared. These instances can be scoped more narrowly with `const`, so that's what this change does. PR-URL: #4940 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@Trott this commit relies on a semver minor change 137f53c#diff-5c0ca4f44209cc4cc68c4dccadbd4a07 would you be able to manually back port it? |
|
@thealphanerd It applies cleanly for me against de0e293 on the |
|
@Trott have you updated the branch? How are you landing it? git am is blowing up for me |
|
It's working for me like this: |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 18, 2016
A few variables in `lib/dgram.js` are redeclared with `var` in a scope where they have already been declared. These instances can be scoped more narrowly with `const`, so that's what this change does. PR-URL: nodejs#4940 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
A few variables in `lib/dgram.js` are redeclared with `var` in a scope where they have already been declared. These instances can be scoped more narrowly with `const`, so that's what this change does. PR-URL: #4940 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
A few variables in `lib/dgram.js` are redeclared with `var` in a scope where they have already been declared. These instances can be scoped more narrowly with `const`, so that's what this change does. PR-URL: #4940 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
A few variables in `lib/dgram.js` are redeclared with `var` in a scope where they have already been declared. These instances can be scoped more narrowly with `const`, so that's what this change does. PR-URL: nodejs#4940 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few variables in
lib/dgram.jsare redeclared withvarin a scopewhere they have already been declared. These instances can be scoped
more narrowly with
const, so that's what this change does.