doc: add more details to process.env #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -424,6 +424,29 @@ process.env.foo = 'bar'; | |||
| console.log(process.env.foo); | |||
| ``` | |||
|
|
|||
| Assigning a property on `process.env` will implicitly call `toString()` | |||
There was a problem hiding this comment.
Maybe just say "implicitly convert the value to a string"
|
LGTM |
evanlucas
force-pushed
the
nullenv
branch
2 times, most recently
from
750d206
to
d9d7aa9
Compare
|
Nits addressed |
|
LGTM |
| Assigning a property on `process.env` will implicitly convert the value | ||
| to a string. | ||
|
|
||
| Example: |
There was a problem hiding this comment.
Maybe scrap that Example: and end the sentence above in a :?
There was a problem hiding this comment.
I'm personally a fan of explicitly marking it as an example, but either way. It seems to be split pretty evenly in that file.
There was a problem hiding this comment.
Yeah, there's a few example markers already in that file, so I guess it's fine.
|
LGTM. |
|
LGTM |
process.env has a few quirks that deserve documenting. The commit documents: - How assigning to process.env will implicitly call `toString()` - How to remove an environment variable from process.env PR-URL: nodejs#4924 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
|
Landed in 8ff9b56. Thanks! |
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
process.env has a few quirks that deserve documenting. The commit documents: - How assigning to process.env will implicitly call `toString()` - How to remove an environment variable from process.env PR-URL: #4924 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
process.env has a few quirks that deserve documenting. The commit documents: - How assigning to process.env will implicitly call `toString()` - How to remove an environment variable from process.env PR-URL: #4924 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
process.env has a few quirks that deserve documenting. The commit documents: - How assigning to process.env will implicitly call `toString()` - How to remove an environment variable from process.env PR-URL: #4924 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
process.env has a few quirks that deserve documenting. The commit documents: - How assigning to process.env will implicitly call `toString()` - How to remove an environment variable from process.env PR-URL: #4924 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
process.env has a few quirks that deserve documenting. The commit documents: - How assigning to process.env will implicitly call `toString()` - How to remove an environment variable from process.env PR-URL: nodejs#4924 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.env has a few quirks that deserve documenting.
The commit documents:
toString()/cc @cjihrig