Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document dangerous symlink behavior #49154

Merged
merged 1 commit into from
Sep 29, 2023

Commits on Sep 22, 2023

  1. doc: document dangerous symlink behavior

    Much earlier, a design decision was made that the permission model
    should not prevent following symbolic links to presumably inaccessible
    locations. Recently, after some back and forth, it had been decided that
    it is indeed a vulnerability that symbolic links, which currently point
    to an accessible location, can potentially be re-targeted to point to a
    presumably inaccessible location. Nevertheless, months later, no
    solution has been found and the issue is deemed unfixable in the context
    of the current permission model implementation, so it was decided to
    disclose the vulnerability and to shift responsibiliy onto users who are
    now responsible for ensuring that no potentially dangerous symlinks
    exist in any directories that they grant access to.
    
    I believe that this design issue might be surprising and that it comes
    with significant security implications for users, so it should be
    documented.
    
    Original vulnerability report: https://hackerone.com/reports/1961655
    tniessen committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    1fd427b View commit details
    Browse the repository at this point in the history