Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix some assumptions in tests #48958

Merged
merged 4 commits into from
Jul 31, 2023
Merged

test: fix some assumptions in tests #48958

merged 4 commits into from
Jul 31, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 29, 2023

Some tests are assuming they will be run from a directory that do not contain any quote or special character in its path. That assumption is not necessary, using JSON.stringify or pathToFileURL ensures the test can be run whatever the path looks like.

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 29, 2023
aduh95 added 3 commits July 29, 2023 11:35
@aduh95
test: fix some assumptions in tests
4397a74 
Some tests are assuming they will be run from a directory that do not
contain any quote or special character in its path. That assumption is
not necessary, using `JSON.stringify` or `pathToFileURL` ensures the
test can be run whatever the path looks like.
@aduh95
fixup! test: fix some assumptions in esm tests
c783660
@aduh95
fixup! test: fix some assumptions in esm tests
ac64ca0
@aduh95 aduh95 force-pushed the esm-test-cwd-assumption branch from ea5b46e to ac64ca0 Compare July 29, 2023 09:36
@aduh95 aduh95 changed the title test: fix some assumptions in esm tests test: fix some assumptions in tests Jul 29, 2023
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52978/

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 30, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 30, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52995/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53001/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53002/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit 384f5d4 into nodejs:main Jul 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 384f5d4

@aduh95 aduh95 deleted the esm-test-cwd-assumption branch July 31, 2023 13:13
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
@targos targos mentioned this pull request Nov 11, 2023
Closed
@targos targos added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Nov 23, 2023
@targos targos mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @targos @MoLow