Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unnecessary temporary creation #48734

Merged
merged 2 commits into from
Jul 20, 2023
Merged

src: remove unnecessary temporary creation #48734

merged 2 commits into from
Jul 20, 2023

Conversation

CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented Jul 11, 2023

The emplace already can create the CleanupHookCallback in place

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 11, 2023
@aduh95 aduh95 requested a review from legendecas July 15, 2023 17:45
@legendecas legendecas added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52815/

This was referenced Jul 18, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52840/

@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Open
22 tasks
@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 20, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 20, 2023
@nodejs-github-bot nodejs-github-bot merged commit ce73e88 into nodejs:main Jul 20, 2023
6 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ce73e88

This was referenced Jul 21, 2023
Open
Open
Open
Open
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@CGQAQ
src: remove unnecessary temporary creation
0b6950f 
PR-URL: nodejs#48734
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@CGQAQ
src: remove unnecessary temporary creation
0d900e0 
PR-URL: nodejs#48734
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@CGQAQ @Ceres6
src: remove unnecessary temporary creation
f13f1bf 
PR-URL: nodejs#48734
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@CGQAQ @Ceres6
src: remove unnecessary temporary creation
5362f85 
PR-URL: nodejs#48734
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@CGQAQ @UlisesGascon
src: remove unnecessary temporary creation
72d134d 
PR-URL: nodejs#48734
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@CGQAQ @RafaelGSS
src: remove unnecessary temporary creation
d759d4f 
PR-URL: #48734
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@CGQAQ @targos
src: remove unnecessary temporary creation
97d8749 
PR-URL: #48734
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: remove unnecessary temporary creation
0ef0602 
PR-URL: nodejs/node#48734
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: remove unnecessary temporary creation
6636a9c 
PR-URL: nodejs/node#48734
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CGQAQ @nodejs-github-bot @anonrig @legendecas @debadree25