Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove OnScopeLeaveImpl's move assignment overload #48732

Merged
merged 3 commits into from
Jul 16, 2023
Merged

src: remove OnScopeLeaveImpl's move assignment overload #48732

merged 3 commits into from
Jul 16, 2023

Conversation

CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented Jul 11, 2023 •
edited
Loading

This PR removes OnScopeLeaveImpl's move assignment overload as it's not valid implementation and also has not been used

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 11, 2023
RaisinTen
RaisinTen reviewed Jul 11, 2023
View reviewed changes
src/util.h Show resolved Hide resolved
@CGQAQ CGQAQ requested a review from RaisinTen July 11, 2023 16:14
RaisinTen
RaisinTen approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you mind updating the PR title, description and the first commit message (requires a force push, so if you're not okay with doing that, let me know and this could be fixed manually while landing your change) to describe the latest change (the deletion of the operator overload and the reasoning)?

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Jul 12, 2023

I'll do that

@CGQAQ CGQAQ changed the title src: fix OnScopeLeaveImpl move assignment src: Remove OnScopeLeaveImpl's move assignment overload as it has not been used Jul 12, 2023
@CGQAQ CGQAQ force-pushed the src-fix-OnScopeLeaveImpl-moveassignment branch from 08692d7 to ba93f28 Compare July 12, 2023 08:11
@CGQAQ
Copy link
Contributor Author

CGQAQ commented Jul 12, 2023

@RaisinTen done

@CGQAQ CGQAQ requested a review from RaisinTen July 12, 2023 08:11
@RaisinTen
Copy link
Contributor

Thanks @CGQAQ! The R in Remove could be changed to lowercase and there is a max limit on the allowed commit title sizes, so it would be better to omit the reason from the title and instead put it in the description. So this title should work: src: remove OnScopeLeaveImpl's move assignment overload
(FYI, the commit message guidelines are documented in https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines)

@CGQAQ CGQAQ force-pushed the src-fix-OnScopeLeaveImpl-moveassignment branch from ba93f28 to 750f797 Compare July 12, 2023 08:32
@CGQAQ CGQAQ changed the title src: Remove OnScopeLeaveImpl's move assignment overload as it has not been used src: remove OnScopeLeaveImpl's move assignment overload Jul 12, 2023
@CGQAQ
Copy link
Contributor Author

CGQAQ commented Jul 12, 2023

@RaisinTen done

@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 12, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 12, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52718/

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Jul 14, 2023

@RaisinTen Is there anything else I need to do?

@RaisinTen
Copy link
Contributor

Nope. :) This change should be good to land after this has been open for a week. However, if someone else approves this PR, it can land instantly. (for reference - https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-10-landing)

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 16, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 16, 2023
@nodejs-github-bot nodejs-github-bot merged commit 373848a into nodejs:main Jul 16, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 373848a

@CGQAQ CGQAQ deleted the src-fix-OnScopeLeaveImpl-moveassignment branch July 17, 2023 00:27
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@CGQAQ @Ceres6
src: remove OnScopeLeaveImpl's move assignment overload
e4f28eb 
... as it's not valid implementation and also has not been used

PR-URL: nodejs#48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@CGQAQ @Ceres6
src: remove OnScopeLeaveImpl's move assignment overload
a44819a 
... as it's not valid implementation and also has not been used

PR-URL: nodejs#48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@CGQAQ @UlisesGascon
src: remove OnScopeLeaveImpl's move assignment overload
5098657 
... as it's not valid implementation and also has not been used

PR-URL: nodejs#48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@CGQAQ @RafaelGSS
src: remove OnScopeLeaveImpl's move assignment overload
07d0fd6 
... as it's not valid implementation and also has not been used

PR-URL: #48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@CGQAQ @targos
src: remove OnScopeLeaveImpl's move assignment overload
358273d 
... as it's not valid implementation and also has not been used

PR-URL: #48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: remove OnScopeLeaveImpl's move assignment overload
4e346b9 
... as it's not valid implementation and also has not been used

PR-URL: nodejs/node#48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
src: remove OnScopeLeaveImpl's move assignment overload
8f423b8 
... as it's not valid implementation and also has not been used

PR-URL: nodejs/node#48732
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CGQAQ @RaisinTen @nodejs-github-bot @lpinca