Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http, https, http2: Server add Symbol.asyncDispose #48548

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! http2: Server add asyncDispose
  • Loading branch information
atlowChemi committed Jun 27, 2023
commit 90f2be5202feb76dbac43a43b4a686a04e4fd200
1 change: 0 additions & 1 deletion doc/api/http2.md
Original file line number Diff line number Diff line change
Expand Up @@ -2070,7 +2070,6 @@ If `callback` is provided, it is not invoked until all active sessions have been
closed, although the server has already stopped allowing new sessions. See
[`net.Server.close()`][] for more details.


#### `server[Symbol.asyncDispose]()`

<!-- YAML
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/http2/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -3192,7 +3192,7 @@ class Http2Server extends NETServer {
}

async [SymbolAsyncDispose]() {
return promisify(super.close).call(this);
return FunctionPrototypeCall(promisify(super.close), this);
}
}

Expand Down