Skip to content

src: revert IS_RELEASE#48505

Closed
RafaelGSS wants to merge 2 commits intonodejs:mainfrom
RafaelGSS:fix-is-release-sec
Closed

src: revert IS_RELEASE#48505
RafaelGSS wants to merge 2 commits intonodejs:mainfrom
RafaelGSS:fix-is-release-sec

Conversation

@RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Jun 20, 2023 •
edited
Loading

I messed up somehow when performing the last 3 releases

@RafaelGSS RafaelGSS added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 20, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

@RafaelGSS RafaelGSS removed the needs-ci PRs that need a full CI run. label Jun 20, 2023
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 20, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52299/

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Jun 21, 2023

lint-py seems to be failing in other PRs (see #48504)

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Jun 21, 2023

I think it's ok to ignore it and land manually?

@Trott
Copy link
Member

Trott commented Jun 21, 2023 •
edited
Loading

lint-py seems to be failing in other PRs (see #48504)

The culprit for that problem appears to be 4c22414. (Although the linter presumably passed when that landed. Maybe a recent change in ruff or something like that?)

@Trott
Copy link
Member

Trott commented Jun 21, 2023 •
edited
Loading

Yeah, looks like a new version of ruff was released today! 😱 We should probably pin the version in Makefile and vcbuild.bat, and update manually. (EDIT: It doesn't exist in vcbuild.bat so I pinned it in Makefile only.)

RafaelGSS and others added 2 commits June 20, 2023 20:46
@RafaelGSS @Trott
src: revert IS_RELEASE
275e512
@Trott
tools: pin ruff version number
e0ec294 
New versions have new rules and end up breaking builds unexpectedly.
@Trott Trott force-pushed the fix-is-release-sec branch from 117cf89 to e0ec294 Compare June 21, 2023 03:46
@Trott Trott added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 21, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52302/

targos pushed a commit that referenced this pull request Jun 21, 2023
@RafaelGSS @targos
src: revert IS_RELEASE
44fd53a 
PR-URL: #48505
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jun 21, 2023
@Trott @targos
tools: pin ruff version number
198affc 
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: #48505
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos
Copy link
Member

targos commented Jun 21, 2023

Landed in 49951ec...198affc

@targos targos closed this Jun 21, 2023
@github-actions github-actions bot mentioned this pull request Jun 23, 2023
Open
30 tasks
RafaelGSS added a commit that referenced this pull request Jul 3, 2023
@RafaelGSS
src: revert IS_RELEASE
5bc13a4 
PR-URL: #48505
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@Trott @RafaelGSS
tools: pin ruff version number
52de27b 
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: #48505
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 13, 2023
@Trott @MoLow
tools: pin ruff version number
438accd 
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: nodejs#48505
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MoLow MoLow mentioned this pull request Jul 13, 2023
Closed
danielleadams pushed a commit that referenced this pull request Jul 17, 2023
@Trott @danielleadams
tools: pin ruff version number
7786d7c 
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: #48505
Backport-PR-URL: #48753
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 17, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
src: revert IS_RELEASE
5e89fa9 
PR-URL: nodejs#48505
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Trott @Ceres6
tools: pin ruff version number
14e9b17 
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: nodejs#48505
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
src: revert IS_RELEASE
9d3956f 
PR-URL: nodejs#48505
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Trott @Ceres6
tools: pin ruff version number
94cc703 
New versions have new rules and end up breaking builds unexpectedly.

PR-URL: nodejs#48505
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

@MoLow MoLow MoLow approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.