test: fix flaky test-runner-watch-mode#48144
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom May 25, 2023
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MoLow
added
fast-track
Contributor
|
Fast-track has been requested by @MoLow. Please 👍 to approve. |
MoLow
added
the
flaky-test
JakobJingleheimer
approved these changes
May 23, 2023
Member
JakobJingleheimer
left a comment
JakobJingleheimer
left a comment
There was a problem hiding this comment.
W00t! Thanks for fixing a flaky test 🙌
I assume the race-conditions are not inherent to the use-case (and do not need to be accounted for).
Member
|
Nit: Is it me or does this test write to the fixtures directory? It should use the testing tmp directory instead. |
Trott
approved these changes
May 23, 2023
aymen94
approved these changes
May 24, 2023
benjamingr
approved these changes
May 24, 2023
MoLow
added
commit-queue-squash
github-actions
bot
removed
the
request-ci
Collaborator
MoLow
added
the
author ready
Trott
approved these changes
May 24, 2023
MoLow
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/48144 ✔ Done loading data for nodejs/node/pull/48144 ----------------------------------- PR info ------------------------------------ Title test: fix flaky test-runner-watch-mode (#48144) Author Moshe Atlow (@MoLow) Branch MoLow:fix-flaky-test-runner-watch-mode -> nodejs:main Labels test, flaky-test, fast-track, author ready, needs-ci, commit-queue-squash Commits 2 - test: fix flaky test-runner-watch-mode - CR: don't use tmpdir only Committers 1 - Moshe Atlow PR-URL: https://github.com/nodejs/node/pull/48144 Reviewed-By: Jacob Smith Reviewed-By: Rich Trott Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48144 Reviewed-By: Jacob Smith Reviewed-By: Rich Trott Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 23 May 2023 18:06:03 GMT ✔ Approvals: 3 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/48144#pullrequestreview-1440586936 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/48144#pullrequestreview-1442268852 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48144#pullrequestreview-1441654648 ℹ This PR is being fast-tracked ✘ This PR needs to wait 24 more hours to land (or 0 hours if there are 2 more approvals (👍) of the fast-track request from collaborators). ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-05-24T15:32:17Z: https://ci.nodejs.org/job/node-test-pull-request/51949/ - Querying data for job/node-test-pull-request/51949/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5071858438 |
MoLow
removed
fast-track
MoLow
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in dd31255 |
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
May 26, 2023
PR-URL: nodejs#48144 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2023
PR-URL: #48144 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #48144 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow
added a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#48144 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48144 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48144 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was able to reproduce the fluke with
tools/test.py -J --timeout=10 --repeat=1500 test/parallel/test-runner-watch-modeand validate this fixes it