doc: improve the documentation of the stdio option#48110
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 30, 2023
Merged
doc: improve the documentation of the stdio option#48110nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
cluster
lpinca
reviewed
May 25, 2023
lpinca
reviewed
May 25, 2023
lpinca
approved these changes
May 25, 2023
Contributor
Author
|
@lpinca I am sorry for bothering but this PR is not getting included in the CI run. I am not able to understand why? |
Member
|
It is a doc only change so there is no need for a full CI run. Can you please use a more descriptive commit title? Something like |
Karnav123
changed the title
Karnav123
changed the title
Contributor
Author
Thank you! Done. |
Member
|
@Karnav123 you changed the PR title not the first commit title. Do you want to try to do it? You need to do a git rebase. If you prefer, we can also do it before landing. |
Contributor
Author
Please rebase and change it. |
jasnell
approved these changes
May 29, 2023
lpinca
added
the
author ready
lpinca
approved these changes
May 30, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 84716d8 |
targos
pushed a commit
that referenced
this pull request
May 30, 2023
Fixes: #47705 PR-URL: #48110 Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Fixes: #47705 PR-URL: #48110 Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Fixes: nodejs#47705 PR-URL: nodejs#48110 Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Fixes: nodejs#47705 PR-URL: nodejs#48110 Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Fixes: nodejs#47705 PR-URL: nodejs#48110 Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc: Add the links to better explain
stdioproperty ofcluster.settingsin the file doc/api/cluster.md#clustersettings.Fixes: issue #47705
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings