doc: add atlowChemi to triagers by atlowChemi · Pull Request #48104 · nodejs/node

atlowChemi · 2023-05-21T16:08:49Z

I recently started contributing to the node project. I am looking forward to getting more involved in the node project, and one day becoming a collaborator 🙏🏽
I have read node's code of conduct, and I will adhere to it

benjamingr · 2023-05-21T16:27:04Z

@gireeshpunathil

README.md

Trott

Entry needs to be moved, but other than that, this looks good to me.

MoLow · 2023-05-21T17:48:50Z

👍🏻 I'l let others approve this as we are brothers ❤️

RaisinTen

LGTM 🎉
cc @nodejs/issue-triage

daeyeon

Welcome aboard!

nodejs-github-bot · 2023-05-28T07:27:19Z

Commit Queue failed

- Loading data for nodejs/node/pull/48104 ✔ Done loading data for nodejs/node/pull/48104 ----------------------------------- PR info ------------------------------------ Title doc: add atlowChemi to triagers (#48104) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch atlowChemi:add-atlowChemi-to-triagers -> nodejs:main Labels doc Commits 2 - doc: add atlowChemi to triagers - re-order Committers 1 - atlowChemi PR-URL: https://github.com/nodejs/node/pull/48104 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Rich Trott Reviewed-By: Qingyu Deng Reviewed-By: Darshan Sen Reviewed-By: Daeyeon Jeong Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Feng Yu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48104 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Rich Trott Reviewed-By: Qingyu Deng Reviewed-By: Darshan Sen Reviewed-By: Daeyeon Jeong Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Feng Yu -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 21 May 2023 16:08:49 GMT ✔ Approvals: 8 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435563635 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435564304 ✔ - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435713363 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435794234 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435797533 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/48104#pullrequestreview-1436005936 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48104#pullrequestreview-1444503120 ✔ - Feng Yu (@F3n67u): https://github.com/nodejs/node/pull/48104#pullrequestreview-1444841370 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48104 From https://github.com/nodejs/node * branch refs/pull/48104/merge -> FETCH_HEAD ✔ Fetched commits as 186307a48432..313f80f3a60e -------------------------------------------------------------------------------- Auto-merging README.md [main 9117246235] doc: add atlowChemi to triagers Author: atlowChemi Date: Sun May 21 19:00:00 2023 +0300 1 file changed, 2 insertions(+) Auto-merging README.md [main 86e4513914] re-order Author: atlowChemi Date: Sun May 21 19:31:26 2023 +0300 1 file changed, 2 insertions(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: add atlowChemi to triagers

PR-URL: #48104
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Qingyu Deng i@ayase-lab.com
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Daeyeon Jeong daeyeon.dev@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Feng Yu F3n67u@outlook.com

[detached HEAD 2449a12bb8] doc: add atlowChemi to triagers
Author: atlowChemi chemi@testim.io
Date: Sun May 21 19:00:00 2023 +0300
1 file changed, 2 insertions(+)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
re-order

PR-URL: #48104
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Qingyu Deng i@ayase-lab.com
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Daeyeon Jeong daeyeon.dev@gmail.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Feng Yu F3n67u@outlook.com

[detached HEAD 58f7772041] re-order
Author: atlowChemi chemi@testim.io
Date: Sun May 21 19:31:26 2023 +0300
1 file changed, 2 insertions(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5103062163

nodejs-github-bot · 2023-05-28T08:28:40Z

Landed in 7f6f17e

PR-URL: #48104 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>

PR-URL: nodejs#48104 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>

doc: add atlowChemi to triagers

854fb63

nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 21, 2023

benjamingr approved these changes May 21, 2023

View reviewed changes

Trott reviewed May 21, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

Trott requested changes May 21, 2023

View reviewed changes

re-order

313f80f

atlowChemi requested a review from Trott May 21, 2023 16:31

Trott approved these changes May 21, 2023

View reviewed changes

Ayase-252 approved these changes May 22, 2023

View reviewed changes

RaisinTen approved these changes May 22, 2023

View reviewed changes

daeyeon approved these changes May 22, 2023

View reviewed changes

VoltrexKeyva approved these changes May 22, 2023

View reviewed changes

lpinca approved these changes May 25, 2023

View reviewed changes

F3n67u approved these changes May 26, 2023

View reviewed changes

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 28, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2023

nodejs-github-bot merged commit 7f6f17e into nodejs:main May 28, 2023

atlowChemi deleted the add-atlowChemi-to-triagers branch May 28, 2023 08:30

targos mentioned this pull request Jun 4, 2023

v20.3.0 release proposal #48332

Merged

danielleadams mentioned this pull request Jul 10, 2023

v18.17.0 release proposal #48694

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

doc: add atlowChemi to triagers#48104

doc: add atlowChemi to triagers#48104
nodejs-github-bot merged 2 commits intonodejs:mainfrom
atlowChemi:add-atlowChemi-to-triagers

atlowChemi commented May 21, 2023 •

edited

Loading

Uh oh!

benjamingr commented May 21, 2023

Uh oh!

Uh oh!

Trott left a comment

Uh oh!

MoLow commented May 21, 2023

Uh oh!

RaisinTen left a comment

Uh oh!

daeyeon left a comment

Uh oh!

nodejs-github-bot commented May 28, 2023

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented May 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Conversation

atlowChemi commented May 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benjamingr commented May 21, 2023

Uh oh!

Uh oh!

Trott left a comment

Choose a reason for hiding this comment

Uh oh!

MoLow commented May 21, 2023

Uh oh!

RaisinTen left a comment

Choose a reason for hiding this comment

Uh oh!

daeyeon left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 28, 2023

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented May 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

atlowChemi commented May 21, 2023 •

edited

Loading