test: ignore helper files in WPTs#48079
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 21, 2023
Merged
Conversation
panva
added
test
github-actions
bot
removed
the
request-ci
Collaborator
aduh95
reviewed
May 19, 2023
anonrig
approved these changes
May 20, 2023
Member
Author
|
I'm hoping to just rename the one offending file that doesn't follow the, I assume unwritten, convention. |
KhafraDev
approved these changes
May 20, 2023
Member
KhafraDev
left a comment
KhafraDev
left a comment
There was a problem hiding this comment.
Although there's no harm in skipping these files, I don't understand why they would time out. Is it a deeper problem with the WPT runner?
Member
Author
The way it selects files that contain tests is definitely one. Combined with the recent change to register a timeout to keep the event loop spinning being another, I wanted to avoid that but the wpt maintainers weren't keen to acknowledging our event loop and called my patch to a particular test a bug hiding solution instead. We can go with this workaround for now until I get the time to pull in the native WPT python tool scripts that build the manifest of files to run. That should avoid any future test file selection problems. |
lpinca
approved these changes
May 21, 2023
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 6439f68 |
fasenderos
pushed a commit
to fasenderos/node
that referenced
this pull request
May 22, 2023
PR-URL: nodejs#48079 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
fasenderos
pushed a commit
to fasenderos/node
that referenced
this pull request
May 22, 2023
PR-URL: nodejs#48079 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2023
PR-URL: #48079 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #48079 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#48079 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48079 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48079 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because daily WPT report started timing out on these helper files. These are not test entrypoints so we're not losing any coverage.