benchmark: use cluster.isPrimary instead of cluster.isMaster#48002
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 17, 2023
Merged
Conversation
nodejs-github-bot
added
benchmark
MoLow
approved these changes
May 14, 2023
tniessen
reviewed
May 14, 2023
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
In benchmarks, this makes sense. In tests, there are already various occurrences of isPrimary, and removing all usages of the old APIs means that they won't be covered by tests anymore. We should still be testing deprecated APIs until they are removed.
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary` for benchmark. Refs: nodejs#47981
deokjinkim
force-pushed
the
230514_benchmark_use_cluster_isprimary
branch
from
7fa0309 to
fab804c
Compare
deokjinkim
changed the title
cluster.isPrimary instead of cluster.isMastercluster.isPrimary instead of cluster.isMaster
Contributor
Author
I agree with you. So revert changed code for test. Thank you for kind review! |
tniessen
approved these changes
May 14, 2023
deokjinkim
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
deokjinkim
added
the
commit-queue
lpinca
approved these changes
May 15, 2023
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/48002 ✔ Done loading data for nodejs/node/pull/48002 ----------------------------------- PR info ------------------------------------ Title benchmark: use `cluster.isPrimary` instead of `cluster.isMaster` (#48002) Author Deokjin Kim (@deokjinkim) Branch deokjinkim:230514_benchmark_use_cluster_isprimary -> nodejs:main Labels cluster, benchmark, author ready, needs-ci Commits 1 - benchmark: use `cluster.isPrimary` instead of `cluster.isMaster` Committers 1 - Deokjin Kim PR-URL: https://github.com/nodejs/node/pull/48002 Refs: https://github.com/nodejs/node/pull/47981 Reviewed-By: Moshe Atlow Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48002 Refs: https://github.com/nodejs/node/pull/47981 Reviewed-By: Moshe Atlow Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 14 May 2023 13:59:40 GMT ✔ Approvals: 3 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48002#pullrequestreview-1425560993 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/48002#pullrequestreview-1425565383 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48002#pullrequestreview-1427261292 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-05-15T13:01:01Z: https://ci.nodejs.org/job/node-test-pull-request/51817/ - Querying data for job/node-test-pull-request/51817/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4992884399 |
deokjinkim
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/48002 ✔ Done loading data for nodejs/node/pull/48002 ----------------------------------- PR info ------------------------------------ Title benchmark: use `cluster.isPrimary` instead of `cluster.isMaster` (#48002) Author Deokjin Kim (@deokjinkim) Branch deokjinkim:230514_benchmark_use_cluster_isprimary -> nodejs:main Labels cluster, benchmark, author ready, needs-ci Commits 1 - benchmark: use `cluster.isPrimary` instead of `cluster.isMaster` Committers 1 - Deokjin Kim PR-URL: https://github.com/nodejs/node/pull/48002 Refs: https://github.com/nodejs/node/pull/47981 Reviewed-By: Moshe Atlow Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48002 Refs: https://github.com/nodejs/node/pull/47981 Reviewed-By: Moshe Atlow Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 14 May 2023 13:59:40 GMT ✔ Approvals: 3 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48002#pullrequestreview-1425560993 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/48002#pullrequestreview-1425565383 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48002#pullrequestreview-1427261292 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-05-16T14:04:27Z: https://ci.nodejs.org/job/node-test-pull-request/51817/ - Querying data for job/node-test-pull-request/51817/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4998309251 |
deokjinkim
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in ca09656 |
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary` for benchmark. Refs: nodejs#47981 PR-URL: nodejs#48002 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cluster.isMasterwas deprecated. So need to usecluster.isPrimaryfor benchmark.Refs: #47981