Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix typo in comment in quic/sessionticket.cc #47754

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

tniessen
Copy link
Member

No description provided.

@tniessen tniessen added fast-track PRs that do not need to wait for 48 hours to land. quic Issues and PRs related to the QUIC implementation / HTTP/3. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 27, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v14.x needs-ci PRs that need a full CI run. labels Apr 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2023
@nodejs-github-bot
Copy link
Collaborator

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 28, 2023
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2023
@nodejs-github-bot nodejs-github-bot merged commit 7ae1360 into nodejs:main Apr 28, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 7ae1360

yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
PR-URL: nodejs#47754
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 28, 2023
PR-URL: nodejs#47754
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 29, 2023
PR-URL: nodejs#47754
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47754
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
@targos targos mentioned this pull request May 2, 2023
targos pushed a commit that referenced this pull request May 3, 2023
PR-URL: #47754
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47754
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47754
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants