http: merge chunks during chunked encoding #47630
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
http
|
What is the context for this? |
tniessen
added
the
performance
ronag
requested changes
Apr 21, 2023
| @@ -866,6 +866,7 @@ function strictContentLength(msg) { | |||
| ); | |||
| } | |||
|
|
|||
| let chunkBuffer = Buffer.alloc(0); | |||
There was a problem hiding this comment.
Having this as a global variable will cause concurrent requests to interleave and become corrupt. The buffer needs to be scoped to the response object itself.
| msg._send(crlf_buf, null, null); | ||
| msg._send(chunk, encoding, null, len); | ||
| ret = msg._send(crlf_buf, null, callback); | ||
| chunkBuffer = Buffer.concat([chunkBuffer, Buffer.from(chunk)]); |
There was a problem hiding this comment.
Concatenating buffers is very slow. They require a memory allocation + memory copy. Just keep an Array of buffers.
Comment on lines
+1047
to
+1053
| if (!this._headerSent && Buffer.byteLength(chunkBuffer)) { | ||
| this._send(NumberPrototypeToString(Buffer.byteLength(chunkBuffer), 16), 'latin1', null); | ||
| this._send(crlf_buf, null, null); | ||
| this._send(chunkBuffer, null, null); | ||
| this._send(crlf_buf, null, callback); | ||
| chunkBuffer = Buffer.alloc(0) | ||
| } |
There was a problem hiding this comment.
This should be done in nextTick (i.e., connectionCorkNT) otherwise, there is no point to all of this... the number of buffered chunks would always be 1.
| @@ -1062,7 +1068,6 @@ OutgoingMessage.prototype.end = function end(chunk, encoding, callback) { | |||
| this.socket.uncork(); | |||
| } | |||
| this[kCorked] = 0; | |||
|
|
|||
| }) | ||
| ); | ||
|
|
||
| server.listen(3000, () => {}); |
There was a problem hiding this comment.
This doesn't test anything related to the problem we are trying to solve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/performance#57