deps: vendor minimatch

[MoLow]

Refs: #40731
this PR includes two commits:
1the first commit adds minimatch as a dependency,
the second commit which is not really ready - is here to demonstrate minimatch usage, exposing some functionality on the node:path module.

once the first commit lands, we can expose globing functionality on node:path, node:fs and use it on node --test and node --watch
I wonder what would be a good way to maintain docs for such exposed functionality, the best example of existing dependency I can think of is undici, but that follows a SPEC

[nodejs-github-bot]

Review requested:

• @nodejs/actions
• @nodejs/tsc

[cjihrig]

Is there a plan for using core's error system and primordials?

[anonrig]

My vote is -1. I'm not in favor of exposing a functionality of a direct dependency that we have no control over and does not use primordials.

[MoLow]

Is there a plan for using core's error system and primordials?

How can that be done?

I'm not in favor of exposing a functionality of a direct dependency that we have no control over and does not use primordials.

I agree that might be an issue. perhaps we only use minimatch for node --test and node --watch without exposing the functionality itself

[benjamingr]

My vote is -1. I'm not in favor of exposing a functionality of a direct dependency that we have no control over and does not use primordials.

Worth mentioning that minimatch's author, isaac used to be (10 years ago) Node's BDFL and expressed interest (many years later, in the npm days probably) in adding it to core. He's also been pretty unresponsive to pings in GitHub about it since.

So it's not like taking some random person's project without asking or anything like that.

(Just giving that context in case it was missing)

[MoLow]

He's also been pretty unresponsive to pings in GitHub about it since.

@benjamingr He has commented two days ago: #40731 (comment)

[isaacs]

Worth mentioning that minimatch's author, isaac used to be (10 years ago) Node's BDFL and expressed interest (many years later, in the npm days probably) in adding it to core. He's also been pretty unresponsive to pings in GitHub about it since.

I'm still here, just busy with stuff. I get a lot of pings, hard to respond to them all :)