Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] wasi: add wasi sock_accept stub #47455

Closed
wants to merge 2 commits into from
Closed

[v18.x backport] wasi: add wasi sock_accept stub #47455

wants to merge 2 commits into from

Commits on Apr 6, 2023

  1. deps: update uvwasi to v0.0.16 

    Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#46434
Refs: nodejs/uvwasi#185
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @mhdawson
    mhdawson committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    e588b63 View commit details
    Browse the repository at this point in the history

  2. wasi: add wasi sock_accept stub 

    Refs: nodejs/uvwasi#185

Add stub for sock_accept so that we have stubs
for all of the sock methods in wasi_snapshot_preview1.
Its a bit awkward as the method was added after the
initial definitial of wasi_snapshot-preview1 but I
think it should be semver minor at most to add
the method.

Depends on nodejs/uvwasi#185
being landed in uvwasi first and an updated version
of uvwasi that includes that being pulled into
Node.js

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#46434
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @mhdawson
    mhdawson committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    74a82ea View commit details
    Browse the repository at this point in the history