Explaining that vm.SourceTextModule() is able to evaluate in current … #47295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
debadree25
reviewed
Mar 29, 2023
There was a problem hiding this comment.
Hey thanks for your contribution, could you just rebase and update the commit message to adhere to the guidelines https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines
Thank You!
Explaining that vm.SourceTextModule() is able to evaluate in current context if non is given Fixes: nodejs#47280
|
I changed the message by force pushing to my fork if thats okay. |
|
That is not a problem! |
debadree25
approved these changes
Mar 29, 2023
|
Also cc @nodejs/vm |
debadree25
added
the
author ready
lpinca
approved these changes
Mar 29, 2023
bnoordhuis
approved these changes
Mar 29, 2023
debadree25
added
the
commit-queue
legendecas
approved these changes
Mar 31, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in b74b9dd |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Explaining that vm.SourceTextModule() is able to evaluate in current context if non is given Fixes: #47280 PR-URL: #47295 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
Explaining that vm.SourceTextModule() is able to evaluate in current context if non is given Fixes: #47280 PR-URL: #47295 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
Explaining that vm.SourceTextModule() is able to evaluate in current context if non is given Fixes: #47280 PR-URL: #47295 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 8, 2023
Explaining that vm.SourceTextModule() is able to evaluate in current context if non is given Fixes: #47280 PR-URL: #47295 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Explaining that vm.SourceTextModule() is able to evaluate in current context if non is given Fixes: #47280 PR-URL: #47295 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers my feature request that is already implemented, just not documented.
Fixes: #47280